Consensus enclaves don't run on sha-ni chips right now. #855
+2
−13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cbeck88
approved these changes
Jul 13, 2021
|
shouldn't this be on a release branch and not master? we cannot cut a hotfix release from fog master right now, there are breaking changes |
|
The sha2 changes are on master. |
eranrund
approved these changes
Jul 13, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
The master branch is currently producing a
SIGILLwhen trying to verify the quote given by a quoting enclave. None of the CPUs we expect to run an enclave on will support the SHA-NI instructions anyways.In this PR
asmfeature from thesha2crate (should never be used anyways)