Always set DEBUG_ENCLAVE to false in IAS prod mode. #852
+2
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Intending to support clients connecting to a "Pre-Production" environment, we were setting
DEBUG_ENCLAVEconditionally, based on whether or not debug assertions were enabled. This has the surprising effect of allowing verifiers compiled in debug mode withIAS_MODE=PRODset to allow debug-mode enclaves to verify.Additionally, now that IAS DEV and "LIV" (PROD) environments both use the same root authority, DEV vs. PROD is sufficient to distinguish whether debug enclaves are supported or not.
We should just remove the conditional and simply make PROD builds always reject debug enclaves, because it removes a footgun.
In this PR
DEBUG_ENCLAVEalwaysfalsewhen not built with thesgx-simorias-devfeatures.