aes-gcm cleanup #850
Merged
aes-gcm cleanup #850
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
July 1, 2021 10:54
- Use mc-oblivious-aes-gcm in mc-crypto-box. - Patch in forked cpufeatures crate for enclave purposes. - Remove (unused) cpuid-bool patch. - Update aes-gcm to 0.9.2. - Update sha2 to 0.9.5 (use cpufeatures instead of cpuid-bool).
eranrund
approved these changes
Jul 8, 2021
added 2 commits
July 8, 2021 10:27
|
I'm going to just merge this and do the test-deploy in fog. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
One of the things which needs to happen to aid in building on M1 is removing the patched
aes-gcmcrate where possible. This removes the in-repomc-crypto-ct-aeadtrait and it's use of a forkedaes-gcmin favor of the standard upstreamaes-gcmin every location other thanmc-crypto-box.In this PR
aes-gcmcratecpuid-boolcrate.cpufeaturescrate to enclave only.mc-oblivious-aes-gcminmc-crypto-box.cpufeaturesinstead ofcpuid-bool).TODO
Future Work
mc-crypto-boxto further reduce the the use of a forked AES implementation to just the ingest enclave.