[reply-functions] Add support to use functions in reply functions #42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonathansamines
force-pushed
the
feature/reply-functions
branch
from
d1bf916
to
4bcfd41
Compare
mmalecki
approved these changes
Apr 8, 2020
| hockInstance | ||
| .get('/url?key=value') | ||
| .reply(200, function(request) { | ||
| const query = url.parse(request.url, true).query; |
There was a problem hiding this comment.
TIL url.parse accepts the second parameter, neat!
|
Published as 1.4.1 🎉 |
|
Thanks, will start using it right away! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some times it is useful to construct responses (body and headers) based on the incoming http request information. This pull request add support for it by allowing to specify functions on both arguments to the
.reply()function.I tried to add test cases for both scenarios, but please let me know if additional tests are required.
Thanks for the amazing library!