Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update pre-commit configs #13

Closed
lorenzwalthert opened this issue Apr 16, 2021 · 5 comments
Closed

Update pre-commit configs #13

lorenzwalthert opened this issue Apr 16, 2021 · 5 comments

Comments

@lorenzwalthert
Copy link
Collaborator

lorenzwalthert commented Apr 16, 2021

To switch from the {styler} fork to {styler.mlr}, we need to change .pre-commit.yaml

-   repo: https://github.com/lorenzwalthert/precommit
    rev: v0.1.3
    hooks:
    -   id: style-files
        args: [--style_pkg=styler.mlr, --style_fun=mlr_style]

With the current release of {precommit}. Later due to lorenzwalthert/precommit#233, we'll need to add additional_dependencies, something along

-   repo: https://github.com/lorenzwalthert/precommit
    rev: v0.2.0
    hooks:
    -   id: style-files
        args: [--style_pkg=styler.mlr, --style_fun=mlr_style]
        additional_dependencies: 
        - mlr-org/styler.mlr

Probably we best wait until this is released.

Maybe (remotely) related: https://github.com/asottile/all-repos

@pat-s
Copy link
Member

pat-s commented May 16, 2021

Is this already working with pre-commit dev? I've bumped the req in the DESCR for now and will observe :)

@lorenzwalthert
Copy link
Collaborator Author

It should work with the dev version of the R package and a recent version of the upstream framework but I’d rather wait until the upstream dev is released. I can do some preliminary testing before that.

@pat-s
Copy link
Member

pat-s commented Oct 2, 2021

Is there a new release of {precommit} anticipated soon?

@lorenzwalthert
Copy link
Collaborator Author

Within the next 3 months probably yes.

@pat-s
Copy link
Member

pat-s commented Dec 25, 2021

I haven't yet checked all repos but I think most are updated meanwhile. Also I shared the precommit wiki page today with the dev team, so other people besides me should be able to deal with it.

@pat-s pat-s closed this as completed Dec 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants