Skip to content
This repository has been archived by the owner on Feb 14, 2023. It is now read-only.

Method signature issues in GraphQLPlaygroundServiceProvider#loadRoutesFrom #45

Closed
voydz opened this issue Oct 20, 2020 · 2 comments
Closed

Method signature issues in GraphQLPlaygroundServiceProvider#loadRoutesFrom #45

voydz opened this issue Oct 20, 2020 · 2 comments

Comments

@voydz
Copy link

voydz commented Oct 20, 2020

Hi,

due to changes in the ServiceProvider signature (laravel/framework#34866) this package fails to load its service provider.

Pull request incoming.

best regards
@voydz voydz mentioned this issue Oct 20, 2020
Closed
@voydz
Copy link
Author

voydz commented Oct 20, 2020

It seems the change was reverted in laravel/framework@7fff6ea.

@spawnia
Copy link
Member

spawnia commented Oct 21, 2020

Thanks @voydz for taking care of this.

@spawnia spawnia closed this as completed Oct 21, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Laravel 8.x compatibility changes
2 participants
@voydz @spawnia