From 898e43ffb990e13f6e23822e370f7452337d5f63 Mon Sep 17 00:00:00 2001 From: harupy <17039389+harupy@users.noreply.github.com> Date: Tue, 14 Dec 2021 18:08:32 +0900 Subject: [PATCH 1/4] try drat Signed-off-by: harupy <17039389+harupy@users.noreply.github.com> --- .github/workflows/master.yml | 3 --- mlflow/R/mlflow/DESCRIPTION | 4 ++-- 2 files changed, 2 insertions(+), 5 deletions(-) diff --git a/.github/workflows/master.yml b/.github/workflows/master.yml index d815760f47daa..0d86bc963a674 100644 --- a/.github/workflows/master.yml +++ b/.github/workflows/master.yml @@ -106,9 +106,6 @@ jobs: run: | install.packages("devtools") remotes::install_deps('mlflow/R/mlflow', dependencies = TRUE, upgrade = FALSE) - # Install `mleap` from archive since it's unavailable on the CRAN repository: - # https://cran.r-project.org/package=mleap - devtools::install_url("https://cran.r-project.org/src/contrib/Archive/mleap/mleap_1.0.0.tar.gz") shell: Rscript {0} - name: Create test environment run: | diff --git a/mlflow/R/mlflow/DESCRIPTION b/mlflow/R/mlflow/DESCRIPTION index 47856f729c255..7531ed62343e1 100644 --- a/mlflow/R/mlflow/DESCRIPTION +++ b/mlflow/R/mlflow/DESCRIPTION @@ -55,12 +55,12 @@ Suggests: h2o, keras, lintr, + mleap, sparklyr, stringi (< 1.4.4), testthat (>= 2.0.0), xgboost -Enhances: - mleap +Additional_repositories: https://harupy.github.io/drat Encoding: UTF-8 RoxygenNote: 7.1.2 Collate: From 609936cee541614d251db861eacf8bf85333d975 Mon Sep 17 00:00:00 2001 From: harupy <17039389+harupy@users.noreply.github.com> Date: Tue, 14 Dec 2021 18:23:17 +0900 Subject: [PATCH 2/4] use mlflow.github.io Signed-off-by: harupy <17039389+harupy@users.noreply.github.com> --- mlflow/R/mlflow/DESCRIPTION | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/mlflow/R/mlflow/DESCRIPTION b/mlflow/R/mlflow/DESCRIPTION index 7531ed62343e1..8d88cba9aada3 100644 --- a/mlflow/R/mlflow/DESCRIPTION +++ b/mlflow/R/mlflow/DESCRIPTION @@ -60,7 +60,7 @@ Suggests: stringi (< 1.4.4), testthat (>= 2.0.0), xgboost -Additional_repositories: https://harupy.github.io/drat +Additional_repositories: https://mlflow.github.io/drat Encoding: UTF-8 RoxygenNote: 7.1.2 Collate: From c55029826a82af10ccf1cf6335bae6644bf1fd9e Mon Sep 17 00:00:00 2001 From: harupy <17039389+harupy@users.noreply.github.com> Date: Tue, 14 Dec 2021 19:05:46 +0900 Subject: [PATCH 3/4] comment Signed-off-by: harupy <17039389+harupy@users.noreply.github.com> --- mlflow/R/mlflow/DESCRIPTION | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/mlflow/R/mlflow/DESCRIPTION b/mlflow/R/mlflow/DESCRIPTION index 8d88cba9aada3..7fa11395fbd7c 100644 --- a/mlflow/R/mlflow/DESCRIPTION +++ b/mlflow/R/mlflow/DESCRIPTION @@ -60,6 +60,12 @@ Suggests: stringi (< 1.4.4), testthat (>= 2.0.0), xgboost +# https://mlflow.github.io/drat was created by following the instructions below: +# https://cran.r-project.org/web/packages/drat/vignettes/DratStepByStep.html +# This repository provides an archive for mleap that was removed from the CRAN repository +# because the mleap maintainers did not fix submission check errors in time. +# See https://cran.r-project.org/package=mleap to confirm. +# `R CMD check` would fail and prevent us from releasing a new version without this field. Additional_repositories: https://mlflow.github.io/drat Encoding: UTF-8 RoxygenNote: 7.1.2 From dcb81d46ac39527485a6c0391c7a56a43898465f Mon Sep 17 00:00:00 2001 From: harupy <17039389+harupy@users.noreply.github.com> Date: Tue, 14 Dec 2021 19:19:02 +0900 Subject: [PATCH 4/4] remove comment Signed-off-by: harupy <17039389+harupy@users.noreply.github.com> --- mlflow/R/mlflow/DESCRIPTION | 6 ------ 1 file changed, 6 deletions(-) diff --git a/mlflow/R/mlflow/DESCRIPTION b/mlflow/R/mlflow/DESCRIPTION index 7fa11395fbd7c..8d88cba9aada3 100644 --- a/mlflow/R/mlflow/DESCRIPTION +++ b/mlflow/R/mlflow/DESCRIPTION @@ -60,12 +60,6 @@ Suggests: stringi (< 1.4.4), testthat (>= 2.0.0), xgboost -# https://mlflow.github.io/drat was created by following the instructions below: -# https://cran.r-project.org/web/packages/drat/vignettes/DratStepByStep.html -# This repository provides an archive for mleap that was removed from the CRAN repository -# because the mleap maintainers did not fix submission check errors in time. -# See https://cran.r-project.org/package=mleap to confirm. -# `R CMD check` would fail and prevent us from releasing a new version without this field. Additional_repositories: https://mlflow.github.io/drat Encoding: UTF-8 RoxygenNote: 7.1.2