Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use len(classes_) instead of len(set(y_true)) #5275

Merged
merged 6 commits into from Jan 17, 2022

Conversation

harupy
Copy link
Member

@harupy harupy commented Jan 17, 2022

What changes are proposed in this pull request?

Use len(classes_) instead of len(set(y_true)) when computing the number of classes.

How is this patch tested?

Existing tests

Does this PR change the documentation?

  • No. You can skip the rest of this section.
  • Yes. Make sure the changed pages / sections render correctly by following the steps below.
  1. Check the status of the ci/circleci: build_doc check. If it's successful, proceed to the
    next step, otherwise fix it.
  2. Click Details on the right to open the job page of CircleCI.
  3. Click the Artifacts tab.
  4. Click docs/build/html/index.html.
  5. Find the changed pages / sections and make sure they render correctly.

Release Notes

Is this a user-facing change?

  • No. You can skip the rest of this section.
  • Yes. Give a description of this change to be included in the release notes for MLflow users.

(Details in 1-2 sentences. You can just refer to another PR with a description if this PR is part of a larger change.)

What component(s), interfaces, languages, and integrations does this PR affect?

Components

  • area/artifacts: Artifact stores and artifact logging
  • area/build: Build and test infrastructure for MLflow
  • area/docs: MLflow documentation pages
  • area/examples: Example code
  • area/model-registry: Model Registry service, APIs, and the fluent client calls for Model Registry
  • area/models: MLmodel format, model serialization/deserialization, flavors
  • area/projects: MLproject format, project running backends
  • area/scoring: MLflow Model server, model deployment tools, Spark UDFs
  • area/server-infra: MLflow Tracking server backend
  • area/tracking: Tracking Service, tracking client APIs, autologging

Interface

  • area/uiux: Front-end, user experience, plotting, JavaScript, JavaScript dev server
  • area/docker: Docker use across MLflow's components, such as MLflow Projects and MLflow Models
  • area/sqlalchemy: Use of SQLAlchemy in the Tracking Service or Model Registry
  • area/windows: Windows support

Language

  • language/r: R APIs and clients
  • language/java: Java APIs and clients
  • language/new: Proposals for new client languages

Integrations

  • integrations/azure: Azure and Azure ML integrations
  • integrations/sagemaker: SageMaker integrations
  • integrations/databricks: Databricks integrations

How should the PR be classified in the release notes? Choose one:

  • rn/breaking-change - The PR will be mentioned in the "Breaking Changes" section
  • rn/none - No description will be included. The PR will be mentioned only by the PR number in the "Small Bugfixes and Documentation Updates" section
  • rn/feature - A new user-facing feature worth mentioning in the release notes
  • rn/bug-fix - A user-facing bug fix worth mentioning in the release notes
  • rn/documentation - A user-facing documentation change worth mentioning in the release notes

Signed-off-by: harupy <17039389+harupy@users.noreply.github.com>
Signed-off-by: harupy <17039389+harupy@users.noreply.github.com>
Signed-off-by: harupy <17039389+harupy@users.noreply.github.com>
@github-actions github-actions bot added the rn/none List under Small Changes in Changelogs. label Jan 17, 2022
Signed-off-by: harupy <17039389+harupy@users.noreply.github.com>
@WeichenXu123
Copy link
Collaborator

Would you paste a snapshot plot as testing result ?

@harupy
Copy link
Member Author

harupy commented Jan 17, 2022

image

Copy link
Collaborator

@WeichenXu123 WeichenXu123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. leave minor comments but not blocker

Signed-off-by: harupy <17039389+harupy@users.noreply.github.com>
Signed-off-by: harupy <17039389+harupy@users.noreply.github.com>
harupy added a commit to mlflow-automation/mlflow that referenced this pull request Jan 17, 2022
Signed-off-by: harupy <hkawamura0130@gmail.com>
Comment on lines +307 to +308
"figure.dpi": 288,
"figure.figsize": [6.0, 4.0],
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This might not be the best approach.

@harupy harupy merged commit 1ddb2c9 into mlflow:master Jan 17, 2022
@harupy harupy deleted the use-n_classes branch January 17, 2022 07:45
harupy added a commit that referenced this pull request Jan 17, 2022
* Generating changelog for MLflow 1.22.1.dev0

Signed-off-by: Jenkins <jenkins@databricks.com>

* Tweaks

Signed-off-by: dbczumar <corey.zumar@databricks.com>

* Tweak

Signed-off-by: dbczumar <corey.zumar@databricks.com>

* Fix typo

Signed-off-by: dbczumar <corey.zumar@databricks.com>

* Small fixes

Signed-off-by: dbczumar <corey.zumar@databricks.com>

* Include model return type

Signed-off-by: dbczumar <corey.zumar@databricks.com>

* Link

Signed-off-by: dbczumar <corey.zumar@databricks.com>

* add #5273

Signed-off-by: harupy <hkawamura0130@gmail.com>

* add #5275

Signed-off-by: harupy <hkawamura0130@gmail.com>

Co-authored-by: Jenkins <jenkins@databricks.com>
Co-authored-by: dbczumar <corey.zumar@databricks.com>
Co-authored-by: harupy <hkawamura0130@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
rn/none List under Small Changes in Changelogs.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants