Print table schema in DB initialization test #5248
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: harupy <17039389+harupy@users.noreply.github.com>
Signed-off-by: harupy <17039389+harupy@users.noreply.github.com>
Signed-off-by: harupy <17039389+harupy@users.noreply.github.com>
harupy
commented
Jan 11, 2022
| @@ -168,10 +168,10 @@ jobs: | |||
| # Run tests | |||
| cd tests/db | |||
| docker-compose build | |||
| docker-compose run mlflow-postgres python log.py | |||
| docker-compose run mlflow-mysql python log.py | |||
| docker-compose run mlflow-postgres python run_checks.py --schema-output schemas/postgres.sql | |||
There was a problem hiding this comment.
Dump the table schema to make it easier to debug locally.
Signed-off-by: harupy <17039389+harupy@users.noreply.github.com>
Signed-off-by: harupy <17039389+harupy@users.noreply.github.com>
Signed-off-by: harupy <17039389+harupy@users.noreply.github.com>
Signed-off-by: harupy <17039389+harupy@users.noreply.github.com>
Signed-off-by: harupy <17039389+harupy@users.noreply.github.com>
harupy
commented
Jan 11, 2022
Comment on lines
+35
to
+36
| volumes: | ||
| - .:/tmp/mlflow |
There was a problem hiding this comment.
Use volumes for faster development cycle instead of copying scripts in the docker image.
Signed-off-by: harupy <17039389+harupy@users.noreply.github.com>
harupy
commented
Jan 11, 2022
Comment on lines
-22
to
-27
|
|
||
| COPY log.py . | ||
| COPY init-mssql-db.sh . | ||
| COPY init-mssql-db.sql . | ||
|
|
||
| RUN chmod +x init-mssql-db.sh |
There was a problem hiding this comment.
We no longer need these line since we mount tests/db when running the container.
Signed-off-by: harupy <17039389+harupy@users.noreply.github.com>
| assert _TRACKING_URI_ENV_VAR in os.environ | ||
|
|
||
| args = parse_args() | ||
| run_logging_operations() |
There was a problem hiding this comment.
is this line for triggering table creation ?
There was a problem hiding this comment.
+ for making sure we can run logging operations successfully.
Signed-off-by: harupy <17039389+harupy@users.noreply.github.com>
harupy
force-pushed
the
print-table-schema
branch
from
86b05a6
to
4e8a2fb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes are proposed in this pull request?
Print a table schema in the DB initialization test to assess the impact of #5249 for postgres, mysql, and mssql.
How is this patch tested?
Confirm the new workflow works.
Does this PR change the documentation?
ci/circleci: build_doccheck. If it's successful, proceed to thenext step, otherwise fix it.
Detailson the right to open the job page of CircleCI.Artifactstab.docs/build/html/index.html.Release Notes
Is this a user-facing change?
(Details in 1-2 sentences. You can just refer to another PR with a description if this PR is part of a larger change.)
What component(s), interfaces, languages, and integrations does this PR affect?
Components
area/artifacts: Artifact stores and artifact loggingarea/build: Build and test infrastructure for MLflowarea/docs: MLflow documentation pagesarea/examples: Example codearea/model-registry: Model Registry service, APIs, and the fluent client calls for Model Registryarea/models: MLmodel format, model serialization/deserialization, flavorsarea/projects: MLproject format, project running backendsarea/scoring: MLflow Model server, model deployment tools, Spark UDFsarea/server-infra: MLflow Tracking server backendarea/tracking: Tracking Service, tracking client APIs, autologgingInterface
area/uiux: Front-end, user experience, plotting, JavaScript, JavaScript dev serverarea/docker: Docker use across MLflow's components, such as MLflow Projects and MLflow Modelsarea/sqlalchemy: Use of SQLAlchemy in the Tracking Service or Model Registryarea/windows: Windows supportLanguage
language/r: R APIs and clientslanguage/java: Java APIs and clientslanguage/new: Proposals for new client languagesIntegrations
integrations/azure: Azure and Azure ML integrationsintegrations/sagemaker: SageMaker integrationsintegrations/databricks: Databricks integrationsHow should the PR be classified in the release notes? Choose one:
rn/breaking-change- The PR will be mentioned in the "Breaking Changes" sectionrn/none- No description will be included. The PR will be mentioned only by the PR number in the "Small Bugfixes and Documentation Updates" sectionrn/feature- A new user-facing feature worth mentioning in the release notesrn/bug-fix- A user-facing bug fix worth mentioning in the release notesrn/documentation- A user-facing documentation change worth mentioning in the release notes