Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Renamed sqlalchemy_store in test plugin to fix file reference #5205

Merged
merged 2 commits into from Jan 12, 2022

Conversation

abhiramr
Copy link
Contributor

What changes are proposed in this pull request?

Renamed tests/resources/mlflow-test-plugin/mlflow_test_plugin/sql_store_alchemy.py to tests/resources/mlflow-test-plugin/mlflow_test_plugin/sqlalchemy_store.py because the former was throwing a warning indicating an absent reference to the latter file.

Minor - Renaming

How is this patch tested?

I installed the mlflow-test-plugin as indicated in the README and ran the mlflow server locally with the plugin being enforced via the URI i.e. MLFLOW_TRACKING_URI=file-plugin:$PWD/mlruns python examples/quickstart/mlflow_tracking.py

Does this PR change the documentation?

  • No. You can skip the rest of this section.
  • Yes. Make sure the changed pages / sections render correctly by following the steps below.
  1. Check the status of the ci/circleci: build_doc check. If it's successful, proceed to the
    next step, otherwise fix it.
  2. Click Details on the right to open the job page of CircleCI.
  3. Click the Artifacts tab.
  4. Click docs/build/html/index.html.
  5. Find the changed pages / sections and make sure they render correctly.

Release Notes

Is this a user-facing change?

  • No. You can skip the rest of this section.
  • Yes. Give a description of this change to be included in the release notes for MLflow users.

(Details in 1-2 sentences. You can just refer to another PR with a description if this PR is part of a larger change.)

What component(s), interfaces, languages, and integrations does this PR affect?

Components

  • area/artifacts: Artifact stores and artifact logging
  • area/build: Build and test infrastructure for MLflow
  • area/docs: MLflow documentation pages
  • area/examples: Example code
  • area/model-registry: Model Registry service, APIs, and the fluent client calls for Model Registry
  • area/models: MLmodel format, model serialization/deserialization, flavors
  • area/projects: MLproject format, project running backends
  • area/scoring: MLflow Model server, model deployment tools, Spark UDFs
  • area/server-infra: MLflow Tracking server backend
  • area/tracking: Tracking Service, tracking client APIs, autologging

Interface

  • area/uiux: Front-end, user experience, plotting, JavaScript, JavaScript dev server
  • area/docker: Docker use across MLflow's components, such as MLflow Projects and MLflow Models
  • area/sqlalchemy: Use of SQLAlchemy in the Tracking Service or Model Registry
  • area/windows: Windows support

Language

  • language/r: R APIs and clients
  • language/java: Java APIs and clients
  • language/new: Proposals for new client languages

Integrations

  • integrations/azure: Azure and Azure ML integrations
  • integrations/sagemaker: SageMaker integrations
  • integrations/databricks: Databricks integrations

How should the PR be classified in the release notes? Choose one:

  • rn/breaking-change - The PR will be mentioned in the "Breaking Changes" section
  • rn/none - No description will be included. The PR will be mentioned only by the PR number in the "Small Bugfixes and Documentation Updates" section
  • rn/feature - A new user-facing feature worth mentioning in the release notes
  • rn/bug-fix - A user-facing bug fix worth mentioning in the release notes
  • rn/documentation - A user-facing documentation change worth mentioning in the release notes

@github-actions
Copy link

@abhiramr Thanks for the contribution! The DCO check failed. Please sign off your commits by following the instructions here: https://github.com/mlflow/mlflow/runs/4652202459. See https://github.com/mlflow/mlflow/blob/master/CONTRIBUTING.rst#sign-your-work for more details.

@github-actions github-actions bot added the rn/none List under Small Changes in Changelogs. label Dec 28, 2021
Signed-off-by: Abhiram R <abhi.darkness@gmail.com>
@harupy
Copy link
Member

harupy commented Jan 4, 2022

@abhiramr I ran MLFLOW_TRACKING_URI=file-plugin:$PWD/mlruns python examples/quickstart/mlflow_tracking.py on master, but it didn't emit a warning. Am I missing something?

@abhiramr
Copy link
Contributor Author

abhiramr commented Jan 8, 2022

@harupy Is that right? 🤔 Let me re-test with the earlier version and get back. Please keep this open till then!

@harupy
Copy link
Member

harupy commented Jan 12, 2022

Hi @abhiramr I was able to reproduce the warning. The proposed change looks good to me!

Signed-off-by: harupy <hkawamura0130@gmail.com>
@harupy harupy merged commit 9362410 into mlflow:master Jan 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
rn/none List under Small Changes in Changelogs.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants