Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix python command in the XGBoost scikit-learn example #5202

Merged
merged 1 commit into from Dec 27, 2021

Conversation

jwyyy
Copy link
Contributor

@jwyyy jwyyy commented Dec 26, 2021

Signed-off-by: Junwen Yao jwyiao@gmail.com

What changes are proposed in this pull request?

train_sklearn.py was re-named to train.py but the python command didn't get updated.

How is this patch tested?

N/A

Does this PR change the documentation?

  • No. You can skip the rest of this section.
  • Yes. Make sure the changed pages / sections render correctly by following the steps below.
  1. Check the status of the ci/circleci: build_doc check. If it's successful, proceed to the
    next step, otherwise fix it.
  2. Click Details on the right to open the job page of CircleCI.
  3. Click the Artifacts tab.
  4. Click docs/build/html/index.html.
  5. Find the changed pages / sections and make sure they render correctly.

Release Notes

Is this a user-facing change?

  • No. You can skip the rest of this section.
  • Yes. Give a description of this change to be included in the release notes for MLflow users.

(Details in 1-2 sentences. You can just refer to another PR with a description if this PR is part of a larger change.)

What component(s), interfaces, languages, and integrations does this PR affect?

Components

  • area/artifacts: Artifact stores and artifact logging
  • area/build: Build and test infrastructure for MLflow
  • area/docs: MLflow documentation pages
  • area/examples: Example code
  • area/model-registry: Model Registry service, APIs, and the fluent client calls for Model Registry
  • area/models: MLmodel format, model serialization/deserialization, flavors
  • area/projects: MLproject format, project running backends
  • area/scoring: MLflow Model server, model deployment tools, Spark UDFs
  • area/server-infra: MLflow Tracking server backend
  • area/tracking: Tracking Service, tracking client APIs, autologging

Interface

  • area/uiux: Front-end, user experience, plotting, JavaScript, JavaScript dev server
  • area/docker: Docker use across MLflow's components, such as MLflow Projects and MLflow Models
  • area/sqlalchemy: Use of SQLAlchemy in the Tracking Service or Model Registry
  • area/windows: Windows support

Language

  • language/r: R APIs and clients
  • language/java: Java APIs and clients
  • language/new: Proposals for new client languages

Integrations

  • integrations/azure: Azure and Azure ML integrations
  • integrations/sagemaker: SageMaker integrations
  • integrations/databricks: Databricks integrations

How should the PR be classified in the release notes? Choose one:

  • rn/breaking-change - The PR will be mentioned in the "Breaking Changes" section
  • rn/none - No description will be included. The PR will be mentioned only by the PR number in the "Small Bugfixes and Documentation Updates" section
  • rn/feature - A new user-facing feature worth mentioning in the release notes
  • rn/bug-fix - A user-facing bug fix worth mentioning in the release notes
  • rn/documentation - A user-facing documentation change worth mentioning in the release notes

Signed-off-by: Junwen Yao <jwyiao@gmail.com>
@github-actions github-actions bot added area/examples Example code rn/none List under Small Changes in Changelogs. labels Dec 26, 2021
Copy link
Collaborator

@WeichenXu123 WeichenXu123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@WeichenXu123 WeichenXu123 merged commit 62bd02b into mlflow:master Dec 27, 2021
@jwyyy jwyyy deleted the fix_xgb_example_doc branch December 28, 2021 00:09
DimaClaudiu pushed a commit to DimaClaudiu/mlflow that referenced this pull request Dec 30, 2021
Signed-off-by: Junwen Yao <jwyiao@gmail.com>
Signed-off-by: Dima Claudiu <claudiu.dima@soleadify.com>
harupy added a commit that referenced this pull request Feb 21, 2022
…5210)

* Fix command in xgboost example readme (#5202)

Signed-off-by: Junwen Yao <jwyiao@gmail.com>
Signed-off-by: Dima Claudiu <claudiu.dima@soleadify.com>

* formatting

Signed-off-by: harupy <17039389+harupy@users.noreply.github.com>

Co-authored-by: Junwen Yao <jwyiao@gmail.com>
Co-authored-by: harupy <17039389+harupy@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/examples Example code rn/none List under Small Changes in Changelogs.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants