Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the experimental decorators on autolog() for all flavors #5028

Merged
merged 2 commits into from Nov 10, 2021

Conversation

liangz1
Copy link
Collaborator

@liangz1 liangz1 commented Nov 9, 2021

Signed-off-by: Liang Zhang liang.zhang@databricks.com

What changes are proposed in this pull request?

Remove the experimental decorators on autolog() for all flavors because it's no longer experimental.

How is this patch tested?

Existing tests.

Release Notes

Is this a user-facing change?

  • No. You can skip the rest of this section.
  • Yes. Give a description of this change to be included in the release notes for MLflow users.

The autolog() API is no longer experimental.

What component(s), interfaces, languages, and integrations does this PR affect?

Components

  • area/artifacts: Artifact stores and artifact logging
  • area/build: Build and test infrastructure for MLflow
  • area/docs: MLflow documentation pages
  • area/examples: Example code
  • area/model-registry: Model Registry service, APIs, and the fluent client calls for Model Registry
  • area/models: MLmodel format, model serialization/deserialization, flavors
  • area/projects: MLproject format, project running backends
  • area/scoring: MLflow Model server, model deployment tools, Spark UDFs
  • area/server-infra: MLflow Tracking server backend
  • area/tracking: Tracking Service, tracking client APIs, autologging

Interface

  • area/uiux: Front-end, user experience, plotting, JavaScript, JavaScript dev server
  • area/docker: Docker use across MLflow's components, such as MLflow Projects and MLflow Models
  • area/sqlalchemy: Use of SQLAlchemy in the Tracking Service or Model Registry
  • area/windows: Windows support

Language

  • language/r: R APIs and clients
  • language/java: Java APIs and clients
  • language/new: Proposals for new client languages

Integrations

  • integrations/azure: Azure and Azure ML integrations
  • integrations/sagemaker: SageMaker integrations
  • integrations/databricks: Databricks integrations

How should the PR be classified in the release notes? Choose one:

  • rn/breaking-change - The PR will be mentioned in the "Breaking Changes" section
  • rn/none - No description will be included. The PR will be mentioned only by the PR number in the "Small Bugfixes and Documentation Updates" section
  • rn/feature - A new user-facing feature worth mentioning in the release notes
  • rn/bug-fix - A user-facing bug fix worth mentioning in the release notes
  • rn/documentation - A user-facing documentation change worth mentioning in the release notes

Signed-off-by: Liang Zhang <liang.zhang@databricks.com>
@liangz1 liangz1 requested a review from harupy November 9, 2021 03:15
@github-actions github-actions bot added area/tracking Tracking service, tracking client APIs, autologging rn/feature Mention under Features in Changelogs. labels Nov 9, 2021
@liangz1 liangz1 requested a review from dbczumar November 9, 2021 03:22
@harupy
Copy link
Member

harupy commented Nov 9, 2021

@liangz1 Can we also update this file?
https://github.com/mlflow/mlflow/blob/41f7a86013b15fb7b18446baddcc6d3f854e0ac0/docs/source/tracking.rst#id70

Signed-off-by: Liang Zhang <liang.zhang@databricks.com>
Copy link
Member

@harupy harupy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@@ -345,7 +345,6 @@ def log_model(
)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we stabilize the other gluon APIs as well?

Copy link
Collaborator

@dbczumar dbczumar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@liangz1 liangz1 merged commit 1e62d2f into mlflow:master Nov 10, 2021
@harupy
Copy link
Member

harupy commented Nov 10, 2021

@liangz1 Have you addressed Corey's comment?

@liangz1
Copy link
Collaborator Author

liangz1 commented Nov 10, 2021

Oh no, I forgot to push after I commit it to local repo. I'll create a separate PR then.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/tracking Tracking service, tracking client APIs, autologging rn/feature Mention under Features in Changelogs.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants