Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SETUP-BUG] Pinned requirement of alembic version getting old #4215

Closed
HansBambel opened this issue Mar 30, 2021 · 5 comments
Closed

[SETUP-BUG] Pinned requirement of alembic version getting old #4215

HansBambel opened this issue Mar 30, 2021 · 5 comments
Labels
area/build Build and test infrastructure for MLflow area/sqlalchemy Use of SQL alchemy in tracking service or model registry bug Something isn't working

Comments

@HansBambel
Copy link

Thank you for submitting an issue. Please refer to our issue policy for information on what types of issues we address.

Please fill in this installation issue template to ensure a timely and thorough response.

System information

  • OS Platform and Distribution (e.g., Linux Ubuntu 16.04): Debian
  • MLflow installed from (source or binary): Source
  • MLflow version (run mlflow --version): It would be 1.15.0
  • Python version: 3.7.9
  • Exact command to reproduce: pip install mlflow or poetry add mlflow

Describe the problem

I would like to install MLflow for our project. This project has as a dependency that the version of alembic is 1.4.2. I have seen that the requirements for MLflow's alembic are <=1.4.1 (due to #3363).
Since future projects with other packages are likely going to need higher alembic versions it would be nice to remove this limiting requirement. Maybe the issue of failing installs was fixed in higher alembic versions already.

Other info / logs

Because mlflow (1.15.0) depends on alembic (<=1.4.1) 
and no versions of mlflow match >1.15.0,<2.0.0, mlflow (>=1.15.0,<2.0.0) requires alembic (<=1.4.1).
@HansBambel HansBambel added the bug Something isn't working label Mar 30, 2021
@dmatrix dmatrix added area/build Build and test infrastructure for MLflow area/sqlalchemy Use of SQL alchemy in tracking service or model registry labels Apr 1, 2021
@dmatrix
Copy link
Contributor

dmatrix commented Apr 1, 2021

cc @harupy any comments on this requirement?

@amenck
Copy link

amenck commented Dec 8, 2021

Is there any plan to address this? We have included mlflow as a requirement in some of our projects, which has limited us to using alembic 1.4.1. In practice I'm sure it would be fine to upgrade to a more recent version and just run the code, since we only use the client and definitely are not interacting with a DB via mlflow... however, since we have mlflow list in our, we would end up getting a conflict with alembic if we tried to update past 1.4.1.

At a broader level, it seems suboptimal that a library which we are using simply as a client has a requirement which involves DB interaction. Ideally, it would be great if there were a way to skip this entirely, since our use of mlflow does not involve any DB interaction.

@huxuan
Copy link

huxuan commented Dec 23, 2021

Same problem here, to be more specific. We joint the usage of mlflow and airflow. And in airflow v2, the least requirement for alembic package is 1.5.1. Do we have any plans to upgrade that?

@jbvaningen
Copy link

I'd like to +1 this issue

@jbvaningen jbvaningen mentioned this issue Jan 10, 2022
29 tasks
@harupy harupy mentioned this issue Jan 12, 2022
29 tasks
@dbczumar
Copy link
Collaborator

dbczumar commented Dec 6, 2022

Fortunately, #5249 has addressed this issue. Thank you for using MLflow!

@dbczumar dbczumar closed this as completed Dec 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/build Build and test infrastructure for MLflow area/sqlalchemy Use of SQL alchemy in tracking service or model registry bug Something isn't working
Projects
None yet
Development

No branches or pull requests

6 participants