tag nested runs with parent run ID #4197
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
area/tracking
Signed-off-by: Yitao Li <yitao@rstudio.com>
yitao-li
force-pushed
the
bugfix/tag-nested-runs
branch
from
689ec97
to
8b5d449
Compare
|
@harupy @kevinykuo @tomasatdatabricks @jdlesage Could any of you take a look at this PR when you have time? |
jinzhang21
reviewed
Oct 15, 2021
| @@ -77,6 +77,13 @@ test_that("mlflow_start_run()/mlflow_end_run() works properly with nested runs", | |||
| expect_equal(mlflow:::mlflow_get_active_run_id(), runs[[i]]$run_uuid) | |||
| run <- mlflow_end_run(client = client, run_id = runs[[i]]$run_uuid) | |||
| expect_identical(run$run_uuid, runs[[i]]$run_uuid) | |||
| if (i > 1) { | |||
There was a problem hiding this comment.
Could you also test that parentRunId doesn't exist for the first (non-nested) run?
|
Haven't heard from the author for a week. Merging as is. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Yitao Li yitao@rstudio.com
What changes are proposed in this pull request?
MLflow R client should tag a nested run with the parent run ID. The 'mlflow.parentRunId' tag is required for nested runs to be displayed properly in MLflow UI.
How is this patch tested?
Unit test
Release Notes
Is this a user-facing change?
MLflow R client now tags a nested run with its parent run ID correctly.
What component(s), interfaces, languages, and integrations does this PR affect?
Components
area/artifacts: Artifact stores and artifact loggingarea/build: Build and test infrastructure for MLflowarea/docs: MLflow documentation pagesarea/examples: Example codearea/model-registry: Model Registry service, APIs, and the fluent client calls for Model Registryarea/models: MLmodel format, model serialization/deserialization, flavorsarea/projects: MLproject format, project running backendsarea/scoring: Local serving, model deployment tools, spark UDFsarea/server-infra: MLflow server, JavaScript dev serverarea/tracking: Tracking Service, tracking client APIs, autologgingInterface
area/uiux: Front-end, user experience, JavaScript, plottingarea/docker: Docker use across MLflow's components, such as MLflow Projects and MLflow Modelsarea/sqlalchemy: Use of SQLAlchemy in the Tracking Service or Model Registryarea/windows: Windows supportLanguage
language/r: R APIs and clientslanguage/java: Java APIs and clientslanguage/new: Proposals for new client languagesIntegrations
integrations/azure: Azure and Azure ML integrationsintegrations/sagemaker: SageMaker integrationsintegrations/databricks: Databricks integrations#closes #4172
How should the PR be classified in the release notes? Choose one:
rn/breaking-change- The PR will be mentioned in the "Breaking Changes" sectionrn/none- No description will be included. The PR will be mentioned only by the PR number in the "Small Bugfixes and Documentation Updates" sectionrn/feature- A new user-facing feature worth mentioning in the release notesrn/bug-fix- A user-facing bug fix worth mentioning in the release notesrn/documentation- A user-facing documentation change worth mentioning in the release notes