Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add pre-commit configuration to all templates #290

Open
Zethson opened this issue Feb 28, 2021 · 0 comments
Open

Add pre-commit configuration to all templates #290

Zethson opened this issue Feb 28, 2021 · 0 comments
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@Zethson
Copy link
Member

Zethson commented Feb 28, 2021

At the moment we have Flake8 running in the linting workflow.

I would suggest to

  1. Add pre-commit to the CI for all templates and remove flake8 from the linting workflow
  2. Add a pre-commit setup with Black (120 lines!), flake8 and editorconfig check (https://github.com/editorconfig-checker/editorconfig-checker.python) and isort
  3. Run pre-commit as a CI job for all templates
  4. Document pre-commit in our documentation
@Zethson Zethson added the enhancement New feature or request label Feb 28, 2021
@Zethson Zethson added this to the 1.11.0 milestone Feb 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants