Improve RTL support #432
Merged
Improve RTL support #432
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Issue mkoryak#411 look like related to isWebkit test preventing negative scrolls updates from issue mkoryak#19 this reverts fixes in commits 3b7508c , 6ddf4b2 and improves the test for mkoryak#19 for RTL
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #411 look like related to isWebkit test preventing negative scrolls updates from issue #19
this reverts fixes in commits 3b7508c , 6ddf4b2 and improves the test for #19 for RTL
Removal of the commits 3b7508c , 6ddf4b2 as this break the aliment of the headers when dir=rtl see https://fiddle.jshell.net/2tgzoLd3/14/