fix: globs in path if cwd is not the cfg file loc #43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I did not use the glob.glob() root_dir argument because it is only available from python 3.10. |
|
@pawamoy Could you please review? Thanks |
|
Sure, I will when I get some time :) |
|
CI failures unrelated, will fix in another PR. I took the liberty to modify your changes a bit, I hope you don't mind. |
No problem, I'm glad I could help and thank you for your review. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #42
based on the documentation: "Non-absolute paths are computed as relative to MkDocs configuration file."