Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Fix broken Sphinx inventory item regex #497

Merged
merged 1 commit into from Dec 13, 2022
Merged

fix: Fix broken Sphinx inventory item regex #497

merged 1 commit into from Dec 13, 2022

Conversation

lmichaelis
Copy link
Contributor

As mentioned in #496, some Sphinx inventories don't match the sphinx_item_regex defined in InventoryItem. Allowing any number of whitespace characters at the end instead of requiring at least one fixes this issue.

Fixes #496.

fix: Fix broken Sphinx inventory item regex
0f42738 
As mentioned in #496, some Sphinx inventories don't match the
`sphinx_item_regex` defined in `InventoryItem`. Allowing any
number of whitespace characters at the end instead of requiring
at least one fixes this issue.

Fixes #496.
pawamoy
pawamoy approved these changes Dec 13, 2022
View reviewed changes
Copy link
Member

@pawamoy pawamoy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@pawamoy
Copy link
Member

pawamoy commented Dec 13, 2022

CI failure unrelated, will fix later.

@pawamoy pawamoy merged commit 348bdd5 into mkdocstrings:master Dec 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pawamoy pawamoy pawamoy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Some Sphinx inventories cannot be parsed
2 participants
@lmichaelis @pawamoy