New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Expose a page.content_title
attribute
#3533
Draft
oprypin
wants to merge
9
commits into
master
Choose a base branch
from
titl
base: master
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is only a specific sub-case of `title` but may make more sense to directly use in some cases.
This was closed without comment. @oprypin could you please explain why? |
Is this feature blocked on #3357 or are they uncoupled? |
Uncoupled |
oprypin
changed the title
Expose a
Expose a Feb 3, 2024
page.content_title
attributepage.content_title
attribute, prefer it for the <title>
oprypin
changed the title
Expose a
Expose a Mar 16, 2024
page.content_title
attribute, prefer it for the <title>
page.content_title
attribute
Can this be merged? |
I didn't merge this because not sure if next maintainers will want to own this code. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similar to
title
but prioritizes the title from the document itself over the title specified in thenav
config.For themes, this should be preferred within the
<title>
tag. To apply the preferred behavior but keep compatibility with older versions, you can use: