Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose a page.content_title attribute #3533

Draft
wants to merge 9 commits into
base: master
Choose a base branch
from
Draft

Expose a page.content_title attribute #3533

wants to merge 9 commits into from

Conversation

oprypin
Copy link
Contributor

@oprypin oprypin commented Dec 30, 2023

Similar to title but prioritizes the title from the document itself over the title specified in the nav config.

For themes, this should be preferred within the <title> tag. To apply the preferred behavior but keep compatibility with older versions, you can use:

<title>{{ page.content_title or page.title }}</title>

This is only a specific sub-case of `title` but may make more sense to directly use in some cases.
@oprypin oprypin closed this Dec 31, 2023
@squidfunk
Copy link
Sponsor Contributor

This was closed without comment. @oprypin could you please explain why?

@ofek
Copy link
Contributor

ofek commented Feb 3, 2024

Is this feature blocked on #3357 or are they uncoupled?

@oprypin
Copy link
Contributor Author

oprypin commented Feb 3, 2024

Uncoupled

@oprypin oprypin changed the title Expose a page.content_title attribute Expose a page.content_title attribute, prefer it for the <title> Feb 3, 2024
@oprypin oprypin changed the title Expose a page.content_title attribute, prefer it for the <title> Expose a page.content_title attribute Mar 16, 2024
@ofek
Copy link
Contributor

ofek commented Apr 8, 2024

Can this be merged?

@oprypin oprypin marked this pull request as draft April 21, 2024 10:23
@oprypin
Copy link
Contributor Author

oprypin commented Apr 21, 2024

I didn't merge this because not sure if next maintainers will want to own this code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Consider changing the precedence of title sources
3 participants