Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to pyproject.toml and Hatch build #2988

Merged
merged 13 commits into from Oct 6, 2022
Merged

Switch to pyproject.toml and Hatch build #2988

merged 13 commits into from Oct 6, 2022

Conversation

oprypin
Copy link
Contributor

@oprypin oprypin commented Oct 2, 2022

Biggest remaining issues:

  • I can't actually remove setup.py because we have commands that require it:
    E.g. python setup.py compile_catalog -t mkdocs

    • I can't set the license because during the above command, setuptools says:
      configuration error: `project.license` must be valid exactly by one definition (2 matches found):
      
          - keys:
              'file': {type: string}
            required: ['file']
          - keys:
              'text': {type: string}
            required: ['text']
      

@facelessuser
Copy link
Contributor

  • I can't actually remove setup.py because we have commands that require it:
    E.g. python setup.py compile_catalog -t mkdocs

What about something like this? https://github.com/facelessuser/Rummage/blob/master/pyproject.toml#L98

@oprypin oprypin changed the base branch from master to nobbl October 2, 2022 21:57
@oprypin oprypin marked this pull request as ready for review October 2, 2022 21:57
@oprypin oprypin changed the base branch from nobbl to master October 3, 2022 17:31
@oprypin oprypin changed the title Switch to Hatch build, add pyproject.toml Switch to pyproject.toml and Hatch build Oct 3, 2022
pyproject.toml Outdated Show resolved Hide resolved
pyproject.toml Outdated Show resolved Hide resolved
.github/workflows/deploy-release.yml Outdated Show resolved Hide resolved
.github/workflows/deploy-release.yml Show resolved Hide resolved
@oprypin
Copy link
Contributor Author

oprypin commented Oct 6, 2022

Sigh, still really scared about losing the "Used by" section, but let's hope for the best

@oprypin oprypin merged commit 30cdac4 into master Oct 6, 2022
@ofek
Copy link
Contributor

ofek commented Oct 6, 2022

Success, it's still there 🙂

@oprypin
Copy link
Contributor Author

oprypin commented Oct 6, 2022

For now, anyway 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants