Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add edit_uri_template config #2927

Merged
merged 4 commits into from Sep 12, 2022
Merged

Add edit_uri_template config #2927

merged 4 commits into from Sep 12, 2022

Conversation

oprypin
Copy link
Contributor

@oprypin oprypin commented Aug 13, 2022

Resolves #1378

@oprypin oprypin mentioned this pull request Aug 13, 2022
Closed
@oprypin oprypin force-pushed the edit-uri branch 3 times, most recently from f380f64 to 488e2aa Compare August 15, 2022 22:39
ultrabug
ultrabug reviewed Aug 16, 2022
View reviewed changes
Copy link
Member

@ultrabug ultrabug left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess we're missing some docstring updates and maybe some documentation about this added feature please

@oprypin oprypin marked this pull request as ready for review September 9, 2022 22:09
ultrabug
ultrabug approved these changes Sep 12, 2022
View reviewed changes
mkdocs/structure/pages.py Show resolved Hide resolved
@oprypin oprypin merged commit 283c362 into master Sep 12, 2022
@oprypin oprypin deleted the edit-uri branch September 17, 2022 16:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ultrabug ultrabug ultrabug approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Improve edit_uri flexability
2 participants
@oprypin @ultrabug