Revert to disregarding the mount path for /livereload/ endpoint #2804
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously there was a pull request "Move livereload endpoint under the mount path (mkdocs#2740)" and it definitely makes sense as a way to make livereload work behind a proxy. However, this change also caused a major annoyance when working on several different sites. Steps to reproduce: 1. `serve` one site (needs to have `site_url` customized) 2. open the site in a browser 3. stop serving it but keep the browser 4. `serve` another site with a different mount point 5. observe spam of "404" errors in the new terminal (also in the old browser but that's whatever) So, this reverts the observable effect of commit fafdcc2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously there was a pull request "Move livereload endpoint under the mount path (#2740)"
and it definitely makes sense as a way to make livereload work behind a proxy.
However, this change also caused a major annoyance when working on several different sites.
Steps to reproduce:
serveone site (needs to havesite_urlcustomized)serveanother site with a different mount pointSo, this reverts the observable effect of commit fafdcc2 by @robertaistleitner