Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure that the edit_uri option does not modify the repo_url #2733

Merged
merged 3 commits into from Mar 26, 2022
Merged

Ensure that the edit_uri option does not modify the repo_url #2733

merged 3 commits into from Mar 26, 2022

Conversation

ofek
Copy link
Contributor

@ofek ofek commented Dec 29, 2021

Resolves #2732

@ofek ofek mentioned this pull request Dec 29, 2021
Closed
5 tasks
@ofek
Copy link
Contributor Author

ofek commented Mar 20, 2022

@oprypin Hello! Can you please take a look at this?

oprypin
oprypin approved these changes Mar 26, 2022
View reviewed changes
Copy link
Contributor

@oprypin oprypin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Sorry for the delay

@oprypin oprypin merged commit 17ff566 into mkdocs:master Mar 26, 2022
@ofek ofek deleted the fix branch March 26, 2022 14:53
@froschdesign froschdesign mentioned this pull request Jun 28, 2022
Merged
@oprypin oprypin mentioned this pull request Aug 13, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oprypin oprypin oprypin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Defining edit_uri as anything other than an empty string modifies the repo_url
2 participants
@ofek @oprypin