Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Depend on 'colorama' on Windows to fix color output in terminal #2606

Merged
merged 1 commit into from Oct 11, 2021

Conversation

oprypin
Copy link
Contributor

@oprypin oprypin commented Oct 10, 2021

Adding the explicit dependency, because

  1. 'click' prior to v8.0 did not have this dependency, it was used "only if present"
  2. We are importing it, let's declare it as such

Fixes #2570

Adding the explicit dependency, because

1. 'click' prior to v8.0 did not have this dependency, it was used "only if present"
2. We *are* importing it, let's declare it as such
@oprypin
Copy link
Contributor Author

oprypin commented Oct 10, 2021

@oprypin oprypin merged commit ba83f90 into mkdocs:master Oct 11, 2021
@oprypin oprypin deleted the colora branch October 11, 2021 17:15
oprypin added a commit that referenced this pull request Oct 2, 2022
oprypin added a commit that referenced this pull request Oct 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support terminal coloring on Windows
1 participant