Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

zh_CN: Complete the translation of the mkdocs theme #2497

Merged
merged 5 commits into from Jul 15, 2021
Merged

zh_CN: Complete the translation of the mkdocs theme #2497

merged 5 commits into from Jul 15, 2021

Conversation

dpy013
Copy link
Contributor

@dpy013 dpy013 commented Jul 13, 2021 

    Complete translation both
    mkdocs
    and
    readthedocs
    themes.
    
    Signed-off-by: xingkong0113 <26911141+xingkong0113@users.noreply.github.com>

@dpy013
zh_CN
a29c337 
Finish translating both mkdocs and readthedocs topics.

Signed-off-by: xingkong0113 <26911141+xingkong0113@users.noreply.github.com>
@ultrabug
Copy link
Member

@xingkong0113 thank you for your contribution!

Could you please add your proposed locale to both mkdocs and readthedocs themes' documentation ?

Cheers

@dpy013
Copy link
Contributor Author

dpy013 commented Jul 13, 2021

@xingkong0113 thank you for your contribution!

Could you please add your proposed locale to both mkdocs and readthedocs themes' documentation ?

Cheers

hi ultrabug
Which file should I change?
thanks

@ultrabug
Copy link
Member

@xingkong0113 thanks, please fill the Last-Translator field too

ultrabug
ultrabug approved these changes Jul 14, 2021
View reviewed changes
Copy link
Member

@ultrabug ultrabug left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I intend to merge this in 1 day

@ultrabug ultrabug merged commit ccc4ce8 into mkdocs:master Jul 15, 2021
@ultrabug
Copy link
Member

Thanks a lot @xingkong0113 :)

@dpy013 dpy013 deleted the zh_CN branch July 15, 2021 10:08
@oprypin
Copy link
Contributor

oprypin commented Jul 16, 2021

@ultrabug You merged this as "Create a merge commit" but you must always select "Squash and merge".

image

@ultrabug
Copy link
Member

👌

@dpy013 dpy013 mentioned this pull request Jul 18, 2021
Closed
@ultrabug ultrabug mentioned this pull request Sep 7, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ultrabug ultrabug ultrabug approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@dpy013 @ultrabug @oprypin