Revert "Ensure site_url and use_directory_urls do not conflict." #2490
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit b89ec57. That commit claims to fix some bugs in interactions with `use_directory_urls`, but in fact there are currently no known unfixed bugs. So there is no need to have that breaking change.
|
I intend to merge this in 1 day |
ultrabug
approved these changes
Jul 12, 2021
jholdstock
added a commit
to jholdstock/dcrdocs
that referenced
this pull request
Aug 3, 2021
No longer need site_url in mkdocs.yml (mkdocs/mkdocs#2490)
This was referenced Aug 6, 2021
dajohi
pushed a commit
to decred/dcrdocs
that referenced
this pull request
Sep 10, 2021
No longer need site_url in mkdocs.yml (mkdocs/mkdocs#2490)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit b89ec57 (#2405)
That commit claims to fix some bugs in interactions with
use_directory_urls, but in fact there are currently no known unfixed bugs.So there is no need to have that breaking change.
See #2189 (comment)
Closes #2189
Closes #2479