Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix gh_deploy with config-file in the current directory #2481

Merged
merged 1 commit into from Jul 5, 2021
Merged

Fix gh_deploy with config-file in the current directory #2481

merged 1 commit into from Jul 5, 2021

Conversation

oprypin
Copy link
Contributor

@oprypin oprypin commented Jun 29, 2021

If the config file is specified as relative and is in the current directory, the dirname transform came out empty, which subprocess doesn't like as cwd.

Fixes #2471

@oprypin
Fix gh_deploy with config-file in the current directory
1c448e0 
If the config file is specified as relative and is in the current directory, the `dirname` transform came out empty, which `subprocess` doesn't like as `cwd`.
@oprypin oprypin merged commit f8b9e96 into mkdocs:master Jul 5, 2021
@oprypin oprypin deleted the reldepl branch July 5, 2021 19:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

gh_deploy doesn't work when a config file is supplied
1 participant
@oprypin