Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix markdownlint test #2095

Merged
merged 7 commits into from May 7, 2020
Merged

Fix markdownlint test #2095

merged 7 commits into from May 7, 2020

Conversation

waylan
Copy link
Member

@waylan waylan commented May 6, 2020

Just experimenting trying to understand why the markdownlint test is failing.

@waylan
Copy link
Member Author

waylan commented May 6, 2020

So Travis is using Node.js version v8.9.1, but markdownlint-cli dropped support for version 8 in 0.22.0 (see igorshubovych/markdownlint-cli#93). Apparently, Node doesn't prevent itself from installing incompatible versions as markdownlint-cli version 0.23.0 is installed.

We could force an older version with npm install -g markdownlint-cli@0.21.0 but I'd rather using a newer version of Node. The Travis docs only list version 12 through 14, so I don't know why we are getting 8.

@waylan
Copy link
Member Author

waylan commented May 6, 2020

Sigh. So if I set the language to node.js I can get Travis to use a more recent version, but then we run into weird Python errors and we need Python to run tox. I guess I could run the test directly from Travis rather than using tox, but that would be inconsistent with the rest of our tests.

@waylan waylan merged commit a4eb4eb into mkdocs:master May 7, 2020
@waylan waylan deleted the mdlint branch May 7, 2020 04:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant