Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support asyncclick? #38

Open
makkus opened this issue Mar 26, 2021 · 0 comments
Open

Support asyncclick? #38

makkus opened this issue Mar 26, 2021 · 0 comments

Comments

@makkus
Copy link

makkus commented Mar 26, 2021

Hi there,

it would be great if this could also support asyncclick. The changes involved would be fairly minimal, just replacing the click import with:

try:
    import asyncclick as click
except:
    import click

in _loader.py would suffice. This would assume that when asyncclick is installed, it should be used (since there is no other reason to install it alongside 'normal' click I can imagine. If that is considered not good enough, it would only be a few more lines to add an instance test against asyncclick.BaseCommand alongside the one against click.BaseCommand.

Thanks for considering!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant