Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support html formatter settings #17

Open
aeschli opened this issue Jan 30, 2018 · 5 comments
Open

Support html formatter settings #17

aeschli opened this issue Jan 30, 2018 · 5 comments

Comments

@aeschli
Copy link

aeschli commented Jan 30, 2018

Testing microsoft/vscode#42361

Ideally, the html settings from VSCode would be used.

IMO the settings used required is "html.format.contentUnformatted" to control which tags should not be changed by the formatter.

@mjbvz
Copy link
Owner

mjbvz commented Jan 30, 2018

Probably depends on microsoft/TypeScript#18604

Currently there is no way that I know of to pass configuration from VSCode to a TS Server plugin

@pdesjardins90
Copy link

pdesjardins90 commented Nov 7, 2018

@mjbvz The related PR was merged last week!

@zlldnv
Copy link

zlldnv commented Nov 20, 2018

I will support it!:'(
It really needed

@mjbvz
Copy link
Owner

mjbvz commented Dec 19, 2018

PRs welcome. Here's where we sync settings with the plugin:

function getConfiguration(): SynchronizedConfiguration {

May also required some upstream changes the plugin: https://github.com/Microsoft/typescript-lit-html-plugin/blob/master/src/configuration.ts

Do people want separate html formatter settings for lit-html or should we re-use the normal html settings?

@sumbad
Copy link

sumbad commented Dec 20, 2018

@mjbvz I think lit-html has to re-use the normal html settings as usual *.html files.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants