Add ., -, and _ to set of unescaped characters in urlencode
#72
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `.snap` file was added by confirming changes from within `cargo insta review`
lucky
commented
Aug 19, 2022
| @@ -1,9 +1,7 @@ | |||
| --- | |||
| source: minijinja/tests/test_templates.rs | |||
| assertion_line: 44 | |||
There was a problem hiding this comment.
I don't know why this changed
There was a problem hiding this comment.
I think your version of cargo-insta is probably too old.
There was a problem hiding this comment.
Actually in this case it's the other way round. Snapshots were made on an older insta version.
lucky
changed the title
. to set of unescaped characters in urlencode., -, and _ to set of unescaped characters in urlencode
|
@mitsuhiko I believe this is ready for review. I'm also interested in creating a PR for the README to add a section on how to develop for this repository. Any feedback here is helpful, thanks! |
|
Thank you for this. Happy to accept a PR for contributing. Ideally put the main contents into a |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I ran
make testand thencargo insta reviewto verify the changes. I'm not sure if there's anything else that's required. (See below for a note on a line that changed and I'm unsure why.)