Value from vec #142
Merged
Value from vec #142
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The largest variant is already at least 16 bytes, so the `Arc` only adds an allocation without gain
SergioBenitez
force-pushed
the
value-from-vec
branch
2 times, most recently
from
2fff05c
to
7dacfa3
Compare
mitsuhiko
requested changes
Nov 10, 2022
|
Alright, cleaned up a few more |
SergioBenitez
force-pushed
the
value-from-vec
branch
2 times, most recently
from
f15891f
to
bf7689e
Compare
Removes the now unnecessary `Value::from_arc_object`. Adds `FromIterator` impls for: * 'Value' for sequences (items of `V: Into<Value>`) * `Value` for maps (items of `(K: Into<StaticKey>, V: Into<Value>)`) Adds 'From' impls to `Value` from: * `Arc<T: Object>` * `u128` * `i128` Finally documents the new functionality.
SergioBenitez
force-pushed
the
value-from-vec
branch
from
bf7689e
to
3b047bd
Compare
|
One thing I now overlooked is that the Value increased in size from 24 bytes to 32 bytes as the i128/u128 is now inlined. I will revisit this separately. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The first commit is an optimization, since what I was assume was originally an optimization attempt is more expensive than simply keeping the actual value around, but feel free to drop it if you'd like. The second is rather important to avoid re-allocating vectors that already contain
Values when creating aValue.Edit: Perhaps that best thing to do is to remove the generic
From<T: Into<Value>> Vec<T>implementation entirely, opting instead for aFrom<Vec<Value>>that does what this one does. That way, the cost is immediately clear, and a more expensive.into()can't accidentally be used.