Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add borrow support for filter arguments #115

Merged
merged 10 commits into from Sep 14, 2022
Merged

Add borrow support for filter arguments #115

merged 10 commits into from Sep 14, 2022

Conversation

mitsuhiko
Copy link
Owner

@mitsuhiko mitsuhiko commented Sep 10, 2022

This allows borrowing for &str and &Value. It's a backwards incompatible change because FunctionArgs::from_values no longer works. I have hidden these implementations now and added a from_args utility as replacement.

This appears to currently require Rust 1.61.0

Fixes #97

@mitsuhiko
Copy link
Owner Author

The issue this is running into might have been this fix in rust: rust-lang/rust#90729

@mitsuhiko mitsuhiko merged commit eeb2203 into main Sep 14, 2022
@mitsuhiko mitsuhiko deleted the feature/borrowing branch September 14, 2022 09:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Change filters/functions/tests to borrow arguments
1 participant