Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement better force update behavior that ignores no-ops #335

Merged
merged 1 commit into from Jan 5, 2023

Conversation

mitsuhiko
Copy link
Owner

Today force update will typically report lots of changed snapshots even if they did not actually change. Additionally it generates pending snapshot files for inline snapshots which result in absolutely no changes. This changes the behavior to compare the serialized contents to the current ones and only write a change if there is one.

Fixes #333

@mitsuhiko mitsuhiko merged commit 27369b5 into master Jan 5, 2023
@mitsuhiko mitsuhiko deleted the feature/better-force-update branch January 5, 2023 10:59
@max-sixty
Copy link
Sponsor Contributor

Thanks!

I almost wonder whether force update should be default True now, given that they're not that volatile (no line numbers now). Or even whether a False option is that helpful.

We'll try making it default True in PRQL at the next insta release and see how that goes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Only print updated files on force_update
2 participants