Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Return results from ToolConfig::from_workspace #324

Closed
mitsuhiko opened this issue Jan 2, 2023 · 1 comment
Closed

Return results from ToolConfig::from_workspace #324

mitsuhiko opened this issue Jan 2, 2023 · 1 comment
Labels
enhancement New feature or request

Comments

@mitsuhiko
Copy link
Owner

At the moment if the tool config is malformed insta panicks. This is what we want in the core insta case but it's not at all intentional for when cargo-insta loads the config.

ToolConfig::from_workspace and ToolConfig::from_manifest_dir should really return results so that cargo-insta can report nicer errors. Refs #322
@mitsuhiko mitsuhiko added the enhancement New feature or request label Jan 2, 2023
@mitsuhiko
Copy link
Owner Author

Fixed in ab93e8d

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@mitsuhiko