Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

YAML snapshot contains an extra newline at EOF. Is this intended? #311

Closed
harupy opened this issue Dec 4, 2022 · 1 comment
Closed

YAML snapshot contains an extra newline at EOF. Is this intended? #311

harupy opened this issue Dec 4, 2022 · 1 comment

Comments

@harupy
Copy link

harupy commented Dec 4, 2022 •
edited

A YAML snapshot contains an extra newline at EOF. For example, line 8 in insta/tests/snapshots/test_basic__unnamed_yaml_vector.snap. Is this intended?

insta/tests/snapshots/test_basic__unnamed_yaml_vector.snap

Lines 1 to 8 in f2469bf

---
source: tests/test_basic.rs
expression: "vec![1, 2, 3]"
---
- 1
- 2
- 3

@harupy harupy mentioned this issue Dec 5, 2022
Closed
@mitsuhiko
Copy link
Owner

I am not sure. Sounds like something that should be fixed but I wonder if this regressed as part of some YAML changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove extra newline in YAML snapshot harupy/insta
2 participants
@mitsuhiko @harupy