Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MSRV Policy #289

Open
mitsuhiko opened this issue Sep 25, 2022 · 2 comments
Open

MSRV Policy #289

mitsuhiko opened this issue Sep 25, 2022 · 2 comments

Comments

@mitsuhiko
Copy link
Owner

mitsuhiko commented Sep 25, 2022

I wanted to originally support old Rust versions for as long as I can since insta is a testing tool and as a user you never want to be in a situation where you cannot test your own crate to your own preferred version ranges because your test tool moves you up.

Unfortunately the world is moving up around insta right now:

A few other things already moved up, some of which we dropped in the process (see #214)

I have not yet decided what I want to do here, but one way is to drop once_cell for now and not to upgrade in similar to postpone this issue for a while. Potentially the discussion in the community settles by then. It seems like the community is abandoning supporting old rustc versions in general (see rust-lang/libs-team#72).

@mitsuhiko
Copy link
Owner Author

For now I'm postponing a decision here. I have restored the intended MSRV policy by dropping once_cell in the interim.

@CosmicHorrorDev
Copy link
Contributor

syn bumped its MSRV up to 1.56 with the v2 release. This alone will bump the MSRV of a lot of projects to at least 1.56 once updates propagate out

I don't think we depend on syn with all features off, but any feature requiring serde will pull it in with a non-semver breaking change

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants