Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid using serde_json for JSON snapshot serialization #261

Closed
mitsuhiko opened this issue Aug 5, 2022 · 1 comment
Closed

Avoid using serde_json for JSON snapshot serialization #261

mitsuhiko opened this issue Aug 5, 2022 · 1 comment
Labels
enhancement New feature or request

Comments

@mitsuhiko
Copy link
Owner

We might not need serde_json to serialize to JSON snapshots. This seems relatively low priority as someone who uses serde and JSON snapshots probably already has serde_json somewhere else in the project.

One potential benefit however is that we might be able to create a more stable snapshot format that is not affected by changes in serde_json. This is probably less of a concern than with YAML where the format likes to break.

Refs #256

@mitsuhiko mitsuhiko added the enhancement New feature or request label Aug 5, 2022
@mitsuhiko
Copy link
Owner Author

Fixed by #265

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant