Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create Smoother Migration Path for Non Serde Uses #259

Closed
mitsuhiko opened this issue Aug 5, 2022 · 0 comments · Fixed by #263
Closed

Create Smoother Migration Path for Non Serde Uses #259

mitsuhiko opened this issue Aug 5, 2022 · 0 comments · Fixed by #263
Labels
enhancement New feature or request

Comments

@mitsuhiko
Copy link
Owner

Latest master no longer depends on serde by default. This means now that all assertion macros that depend on serde are hidden behind features. This also means that many types no longer implement Serialize. For at least the macros it would be sensible to provide a migration path that looks something like this:

Add a hidden feature _legacy_default_serialization. If this is enabled it auto gates the yaml and json based functionality. However if not also the json (or yaml respectively) features are enabled it emits a deprecation warning that the features need to be enabled.

Followup to #255

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant