Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Exit code of cargo insta test on changes in snapshots? #222

Closed
max-sixty opened this issue Mar 26, 2022 · 0 comments · Fixed by #224
Closed

Exit code of cargo insta test on changes in snapshots? #222

max-sixty opened this issue Mar 26, 2022 · 0 comments · Fixed by #224

Comments

@max-sixty
Copy link
Sponsor Contributor

Currently when cargo insta test returns info: 4 snapshots to review, it returns an exit code of 0.

Is that intended? I was a bit surprised. I could understand the rationale — cargo-insta successfully stored the pending snapshots. But it's a different behavior that cargo test.

Feel free to close without explanation if this is decided, thanks.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Set non zero status code for pending tests mitsuhiko/insta
1 participant
@max-sixty