Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bleach is deprecated #438

Open
seansica opened this issue Jun 28, 2023 · 0 comments
Open

Bleach is deprecated #438

seansica opened this issue Jun 28, 2023 · 0 comments
Assignees

Comments

@seansica
Copy link
Contributor

Per Mozilla, as of Jan 23, Bleach is deprecated: mozilla/bleach#698 (comment)

They will continue to provide security updates and bug fixes for approximately one year.

We need to replace Bleach.

ammonia looks like a promising solution but there may be others.

This is a good opportunity to refactor a bit. The process of sanitizing the HTML and generating the seed file (index.json) for the search index should be decoupled. There ought to be a separation of concerns between the generation of the website content and the generation of the search index.

Order of events:

  1. Build website (Pelican/update-attack.py)
  2. Generate seed file for search index (e.g., ammonia)
  3. Generate search index (attack-search --> npm/webpack)
@seansica seansica self-assigned this Jun 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

When branches are created from issues, their pull requests are automatically linked.

1 participant