Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

header names are needlessly line-wrapped #2936

Open
majewsky opened this issue Feb 28, 2018 · 5 comments · May be fixed by #6799
Open

header names are needlessly line-wrapped #2936

majewsky opened this issue Feb 28, 2018 · 5 comments · May be fixed by #6799
Labels
area/console help wanted kind/ux User experience improvements

Comments

@majewsky
Copy link

Even though there is plenty of horizontal space (as can be seen from the width of the "Request-Response-Details" tab bar).

screen

@fenilgandhi
Copy link
Contributor

Hi, i had a look into the source but it turns out that they are not needlessly wrapped up but it is intentional to be on the new line. It may not be clear for smaller urls but for longer urls it make the header responses visible which would otherwise be wrapped up.
If you still have any other suggestions, feel free to share them.

@majewsky
Copy link
Author

majewsky commented Mar 8, 2018

I'm not sure I understand what you're saying. Just because header values could be larger, doesn't mean we have to line-wrap the header names when they aren't.

@koknaroglu
Copy link

I want to think about this question. Which files can i work on?

@mhils mhils added kind/ux User experience improvements and removed kind/bug labels Apr 6, 2022
@mhils
Copy link
Member

mhils commented Apr 6, 2022

The correct fix here is to

  1. Get available space.
  2. Calculate maximum header name length.
  3. Calculate maximum header value length.
  4. Make sure that the header name takes up at least 30 chars, but more if the space is not fully used.

@urvashi2004
Copy link

Hello
Wouldn't it be better to store the number of characters in the header length and then assign if they need wrapping or not according to their length?

@gellge gellge linked a pull request Apr 14, 2024 that will close this issue
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/console help wanted kind/ux User experience improvements
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants