Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support to Sequence[int] similar to Sequence[str] for addon commands #6660

Open
m417z opened this issue Feb 14, 2024 · 1 comment
Open

Add support to Sequence[int] similar to Sequence[str] for addon commands #6660

m417z opened this issue Feb 14, 2024 · 1 comment
Labels
kind/feature New features / enhancements

Comments

@m417z
Copy link

m417z commented Feb 14, 2024

Problem Description

Addon commands can be sequences, but the only supported sequence is of type str. Add support for Sequence[int].

mitmproxy/docs/src/content/addons-commands.md

Line 120 in 1f2e1a2

- Sequences: `typing.Sequence[str]`

mitmproxy/mitmproxy/optmanager.py

Line 368 in 1f2e1a2

if o.typespec == Sequence[str]:

Additional context

Example use case: passing multiple status codes.
realgam3/pymultitor#38
@m417z m417z added the kind/feature New features / enhancements label Feb 14, 2024
@m417z m417z mentioned this issue Feb 14, 2024
Merged
@mhils
Copy link
Member

mhils commented Feb 14, 2024

Happy to merge a PR for this! 😃

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/feature New features / enhancements
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mhils @m417z