Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add more commands to start applications with mitmproxy preconfigured #5247

Open
5 tasks
mhils opened this issue Apr 6, 2022 · 3 comments · May be fixed by #6035
Open
5 tasks

Add more commands to start applications with mitmproxy preconfigured #5247

mhils opened this issue Apr 6, 2022 · 3 comments · May be fixed by #6035
Labels
area/addons help wanted kind/feature New features / enhancements kind/ux User experience improvements

Comments

@mhils
Copy link
Member

mhils commented Apr 6, 2022

Many mitmproxy users only want to proxy one specific application. We already have a browser.start command to boot up a Chrome instance, it would be very useful to have similar wrappers for other browsers and applications:

  • Firefox
  • Edge
  • Safari
  • Docker Containers
  • Android Devices

Implementation Steps

  1. Take one of the targets above and figure out how to start it with a proxy server preconfigured.
  2. Extend the browser addon with a custom command that invokes the application.
  3. Add a test in https://github.com/mitmproxy/mitmproxy/blob/main/test/mitmproxy/addons/test_browser.py. These tests aren't particularly useful as we want to mock the actual application, but we require 100% test coverage for all builtin addons.
@mhils mhils added kind/feature New features / enhancements help wanted area/addons kind/ux User experience improvements labels Apr 6, 2022
@mhils mhils mentioned this issue Apr 6, 2022
Closed
@roniemartinez
Copy link

roniemartinez commented Apr 11, 2022 •
edited

Maybe the browser launcher from HTTPToolkit will give you an idea.

I implemented a simple snippet to get the browser paths for OSX based on https://github.com/httptoolkit/browser-launcher/tree/master/lib/darwin

You can find it here: https://gist.github.com/roniemartinez/771b8a65013a87a9137ca29224fe455d

@mohamedmostafadawood
Copy link

Maybe the browser launcher from HTTPToolkit will give you an idea.

I implemented a simple snippet to get the browser paths for OSX based on https://github.com/httptoolkit/browser-launcher/tree/master/lib/darwin

You can find it here: https://gist.github.com/roniemartinez/771b8a65013a87a9137ca29224fe455d

I sent you a message via Twitter to ask for some help. I really would appreciate your consideration : ).

mrwacky42 added a commit to mrwacky42/mitmproxy that referenced this issue Oct 31, 2022
@mrwacky42
Add support for Firefox
b5f7049 
Fixes mitmproxy#5247
@mrwacky42 mrwacky42 mentioned this issue Oct 31, 2022
Closed
2 tasks
@mhils mhils mentioned this issue Jan 5, 2023
Closed
@Rishabhg71 Rishabhg71 linked a pull request Mar 31, 2023 that will close this issue
Draft
7 tasks
@mhils mhils mentioned this issue Jan 8, 2024
Open
@oge1ata
Copy link

oge1ata commented Mar 25, 2024

Hi @mhils could I know the current state of this issue?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/addons help wanted kind/feature New features / enhancements kind/ux User experience improvements
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Added more commands to start applications with mitmproxy preconfigured Rishabhg71/mitmproxy
4 participants
@mhils @roniemartinez @oge1ata @mohamedmostafadawood