Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test fails on Ember 2.12 and Ember current release #39

Open
mitchlloyd opened this issue Feb 25, 2017 · 4 comments · May be fixed by #53
Open

Test fails on Ember 2.12 and Ember current release #39

mitchlloyd opened this issue Feb 25, 2017 · 4 comments · May be fixed by #53

Comments

@mitchlloyd
Copy link
Owner

This assertion fails on Ember Canary, throwing the error:

Error: Assertion Failed: ember-islands could not find a component named "unknown-component" in your Ember application.

So clearly the code is working, but the assertion just isn't catching the error.

@mitchlloyd mitchlloyd changed the title Test failes on Ember Canary Test fails on Ember Canary Feb 25, 2017
@mitchlloyd
Copy link
Owner Author

Related Ember issue: emberjs/ember.js#15013

@acorncom
Copy link

acorncom commented Feb 6, 2019

@mitchlloyd looks like this could probably be closed? The above issue has been fixed

@mitchlloyd
Copy link
Owner Author

Tried unskipping, but got the expected on 2.12 (makes sense) and a new error on current release (makes less sense). https://travis-ci.org/mitchlloyd/ember-islands/builds/490369176

I'll change this issue to cover at least getting this test running on the current release and conditionally skip for 2.12.

@mitchlloyd mitchlloyd changed the title Test fails on Ember Canary Test fails on Ember 2.12 and Ember current release Feb 8, 2019
@rwjblue
Copy link

rwjblue commented Feb 8, 2019

Provides useful error message when a component can't be found

is the failure on current release, maybe the error formats changed?

@mitchlloyd mitchlloyd linked a pull request Feb 10, 2019 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants