allow decoding nested struct ptrs to map #271
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vlanse
force-pushed
the
fix/decode-nested-pointer-structs-to-map
branch
from
2a4f429
to
94c41ea
Compare
|
Hello, Any news on merging this PR? This fix is much needed. Thanks |
|
This looks great. Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will address #267 (see added tests for example)
I've seen #231, and paid special attention that existing tests will not be broken. BTW, for me fixing #231 broken desired behaviour, but I understand the needs and importance of compatibility :)
My case is rather simple:
I have a struct with another embedded struct that also contains pointers to another structs along with "basic" type values. Before the fix, those embedded structs were not decoded into maps (i.e.
map[string]interface{}) although they hadmapstructuretags set appropriately. Added test could serve as a simplified example for described situation.