Add ErrorUnset option to DecoderConfig and Unset array to Metddata #225
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit extends the DecoderConfig with an option to fail decoding if there exist fields in the target struct, which haven't been set during decoding due to a missing, corresponding value in the input map. Accordingly, the Metadata has been extended with an Unset array to receive all field names which have not been set during decoding.
lanlanlanlanlanchengzhu
approved these changes
Oct 26, 2021
|
Okay, I like this. See my comment in #167 for what seems contradictory, but the reason I like this is because its purely related to decoder state. Its possible #167 could be construed this way too so maybe I'm just looking at this from another angle. I like that this isn't a per-field "validation" pass, its more of a decode-behavior validation and metadata extraction. |
|
Really clean PR, thank you |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit extends the DecoderConfig with an option to fail decoding
if there exist fields in the target struct, which haven't been set
during decoding due to a missing, corresponding value in the input map.
Accordingly, the Metadata has been extended with an Unset array to
receive all field names which have not been set during decoding.