This repository was archived by the owner on Jul 22, 2024. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If HOME is not defined and getent(1) is not found, dirUnix() currently immediately returns an error without even trying the third method (
sh -c 'cd && pwd'
). It means HOME is the only source for obtaining the home directory on Darwin where getent(1) is missing.One possible bug here is that the condition to detect if getent(1) is not found might be reversed, which I addressed in the first commit.
The second commit adds a fallback method specially for Darwin. It is to execute dscl(1) via the shell, so no dependency on cgo will be involved.