Fix bug in which "fooasdf -o=foo" is incorrectly identified as the subcommand "foo" #93
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add a failing test demonstrating that "fooasdf -o=foo" is incorrectly matched to the subcommand "foo".
When determining the string to use when querying the radix tree for the longest subcommand, exclude any argument beginning with a "-", since this is a flag and not a subcommand. This fixes a bug in which "fooasdf -o=foo" is matched to the subcommand "foo" due to logic further down on line 704.
|
Looks great. Very amusing no one has ever noticed this before. :) Thank you! I think this approach is totally fine (and maybe the best), as long as we have a test and there is no user-facing API change we can always improve the implementation if we find a better approach. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #92
There are a number of ways to fix this. Another approach would be to modify the regex used on line 704 to explicitly exclude cases in which the string ending in the subcommand is itself a flag.