Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps: bump Masterminds/sprig to v3 (go.mod enabled version) #87

Merged
merged 1 commit into from Apr 21, 2022

Conversation

radeksimko
Copy link
Contributor

As can be seen from the go.mod diff, this bumps sprig to latest v3, which is go.mod-enabled.

This reduces the noise in go.mod which no longer has to track transitive dependencies.

Despite the major version bump, according to the changelog v2 -> v3 changes seem fairly minimal and don't affect Go API at all. It is worth calling out this update in cli's changelog though as behaviour changes may affect downstream consumers.

@egonbraun
Copy link

This also fixes the following security issue:

✗ Medium severity vulnerability found in github.com/Masterminds/goutils
  Description: Insecure Randomness
  Info: https://snyk.io/vuln/SNYK-GOLANG-GITHUBCOMMASTERMINDSGOUTILS-1296313
  Introduced through: github.com/mitchellh/cli@1.1.2
  From: github.com/mitchellh/cli@1.1.2 > github.com/Masterminds/sprig@2.22.0 > github.com/Masterminds/goutils@1.1.0
  Fixed in: 1.1.1

Is @mitchellh the only one that can approve your PR? I am getting the feeling I cannot rely on this project anymore since your PR was opened months ago. :/

Anyway, thanks for the PR and I hope it gets merged soon.

@mitchellh mitchellh merged commit 878f83b into mitchellh:master Apr 21, 2022
@radeksimko radeksimko deleted the bump-sprig branch April 21, 2022 17:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants